arbitrary_source_item_ordering: Make alphabetic ordering in module item groups optional
#13718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
y21
approved these changes
Nov 30, 2024
|
☔ The latest upstream changes (presumably 1dddeab) made this pull request unmergeable. Please resolve the merge conflicts. |
decryphe
force-pushed
the
source-ordering-improvements
branch
3 times, most recently
from
9f4ba3c to
5b2f954
Compare
decryphe
force-pushed
the
source-ordering-improvements
branch
from
5b2f954 to
438cd30
Compare
y21
reviewed
Feb 11, 2025
decryphe
force-pushed
the
source-ordering-improvements
branch
7 times, most recently
from
b4673c2 to
058104f
Compare
decryphe
force-pushed
the
source-ordering-improvements
branch
from
058104f to
c0d8704
Compare
…ult: off) From feedback to this lint after its inclusion in clippy 1.82, this has turned out to be the most requested improvement. With this improvement, it is possible to make the lint check certain top-level structural checks on modules (e.g. use statements and module inclusions at the top), but still leaving everything else up to the developer.
decryphe
force-pushed
the
source-ordering-improvements
branch
from
c0d8704 to
5df6887
Compare
y21
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From feedback to the
arbitrary_source_item_orderinglint after its inclusion in clippy 1.82, making alphabetic ordering within module item groups has turned out to be the most requested improvement. With this improvement, it is possible to make the lint perform certain top-level structural checks on modules (e.g. use statements and module inclusions at the top), but still leaving everything else up to the developer.Implements parts of the suggestions from #13675. A catch-all-group is still to be implemented.
changelog: [
arbitrary_source_item_ordering]: Make alphabetic ordering in module item groups optional (off by default)