Skip to content

Conversation

@flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 8, 2024

The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book.

r? @xFrednet

I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI.

This is just copy and paste of the current README file on master.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 8, 2024
@xFrednet
Copy link
Contributor

xFrednet commented Apr 8, 2024

LGTM, thank you! You can r=me once the CI is happy :)

The lint table and the restriction group description was improved in rust-lang#10385,
but only in the README. Apply the same changes to the book.
@flip1995
Copy link
Member Author

flip1995 commented Apr 9, 2024

Forgot to copy the links...

@bors r=xFrednet

@bors
Copy link
Contributor

bors commented Apr 9, 2024

📌 Commit 23225e1 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 9, 2024

⌛ Testing commit 23225e1 with merge 1adc5a9...

bors added a commit that referenced this pull request Apr 9, 2024
Consistent lint group table in book and README

The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book.

r? `@xFrednet`

I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI.

This is just copy and paste of the current README file on `master`.

changelog: none
@bors
Copy link
Contributor

bors commented Apr 9, 2024

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

flip1995 commented Apr 9, 2024

Huh? Integration test of rand failed without any log 😕

@bors retry

@bors
Copy link
Contributor

bors commented Apr 9, 2024

⌛ Testing commit 23225e1 with merge ccc93f9...

@bors
Copy link
Contributor

bors commented Apr 9, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing ccc93f9 to master...

@bors bors merged commit ccc93f9 into rust-lang:master Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants