Update readme description of restriction lints to dissuade casual use.
#10385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
readme_restriction
branch
from
ec4eff6 to
8631a1e
Compare
xFrednet
reviewed
Feb 21, 2023
Contributor
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
A small suggestion, otherwise it looks good to me. I like that the table now contains all categories :)
Jarcho
force-pushed
the
readme_restriction
branch
from
8631a1e to
bf7c209
Compare
xFrednet
approved these changes
Feb 22, 2023
Contributor
|
Looks good to me, thank you! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 8, 2024
The lint table and the restriction group description was improved in rust-lang#10385, but only in the README. Apply the same changes to the book.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 9, 2024
The lint table and the restriction group description was improved in rust-lang#10385, but only in the README. Apply the same changes to the book.
bors
added a commit
that referenced
this pull request
Apr 9, 2024
Consistent lint group table in book and README The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book. r? `@xFrednet` I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI. This is just copy and paste of the current README file on `master`. changelog: none
bors
added a commit
that referenced
this pull request
Apr 9, 2024
Consistent lint group table in book and README The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book. r? `@xFrednet` I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI. This is just copy and paste of the current README file on `master`. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some stronger wording about not enabling
restrictionlints. I've seen it come up a few times where people are confused about what therestrictioncategory is for and end up casually enabling lints from it (or the whole category).changelog: None