Skip to content

FR: redundant_field_names should distinguish between all and some fields matching #3422

@taralx

Description

@taralx

redundant_field_names fires on any field being a match. This impairs readability in cases like this:

let thingy = Thingy {
   calc: big + calculation,
   redundant: redundant,
   other: stuff.into(),
};

As you can see, if you apply the suggestion, you end up with a weird line that is different from the rest. I suggest that the lint be split such that it distinguishes between "all fields are redundant" and "some fields are redundant".

Metadata

Metadata

Assignees

Labels

C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messagesL-styleLint: Belongs in the style lint groupgood first issueThese issues are a good way to get started with Clippy

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions