Skip to content

Commit

Permalink
chore: fix clippy lint
Browse files Browse the repository at this point in the history
  • Loading branch information
@Stebalien
Stebalien committed Jul 1, 2019
1 parent 8d6ab7a commit 2dc0f13
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/lib.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@
)]
#![cfg_attr(test, deny(warnings))]
#![deny(rust_2018_idioms)]
#![allow(clippy::redundant_field_names)]

#[macro_use]
extern crate cfg_if;
Expand Down

2 comments on commit 2dc0f13

@tesuji
Copy link
Contributor

@tesuji tesuji commented on 2dc0f13 Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove redundant field name in

tempfile/src/spooled.rs

Line 68 in 2dc0f13

max_size: max_size,

instead?

@Stebalien
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixing punned and non-punned fields is confusing, IMO. See rust-lang/rust-clippy#3422.

Please sign in to comment.