Bump to 0.28 #841
Merged
Bump to 0.28 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Manishearth you need to update the lock file: diff --git a/Cargo.lock b/Cargo.lock
index 1615200..6ea1045 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1,6 +1,6 @@
[root]
name = "bindgen"
-version = "0.27.0"
+version = "0.27.1"
dependencies = [
"aster 0.41.0 (registry+https://github.com/rust-lang/crates.io-index)",
"cexpr 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)", |
|
r=me with that |
Manishearth
force-pushed
the
bump
branch
2 times, most recently
from
8045932 to
eb46d65
Compare
|
Let's don't push on this. It seems the bindgen still doesn't work for stylo. |
|
I'm aware, been investigating that. See #842 (comment) |
|
I think I'm hitting a different one likely regressed from #829. |
|
☔ The latest upstream changes (presumably #845) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors-servo r=fitzgen |
|
📌 Commit d4da81a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 24, 2017
Bump to 0.28 Brings in #822 which unblocks https://bugzilla.mozilla.org/show_bug.cgi?id=1366956, and also #829 which should greatly reduce merge conflicts in checked in bindings.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in #822 which unblocks https://bugzilla.mozilla.org/show_bug.cgi?id=1366956,
and also #829 which should greatly reduce merge conflicts in checked in bindings.