Stop Rust from prepending underscore before '?' for win32 #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @emilio |
emilio
approved these changes
Jul 18, 2017
| match symbol.chars().next().unwrap() { | ||
| // Stripping leading underscore for all names on Darwin and | ||
| // C linkage functions on Win32. | ||
| '_' => { symbol.remove(0); } |
There was a problem hiding this comment.
nit: No need for braces, here and below.
There was a problem hiding this comment.
No, it needs. String::remove returns char and String::insert returns nothing.
|
@bors-servo r=emilio |
|
📌 Commit 4f8de62 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 18, 2017
Stop Rust from prepending underscore before '?' for win32 This fixes #819. It also includes tests for different platforms which are not supposed to be affected, so that we won't regress them in the future either. The prefix `\x01` char is necessary for Win32. See also [msvc32_symbolify function in regen_atoms.py](https://github.com/servo/servo/blob/1b6d29e31996c87218352b825aa93e01909a6a24/components/style/gecko/regen_atoms.py#L35-L38).
|
☀️ Test successful - status-travis |
Merged
bors-servo
pushed a commit
that referenced
this pull request
Jul 24, 2017
Bump to 0.28 Brings in #822 which unblocks https://bugzilla.mozilla.org/show_bug.cgi?id=1366956, and also #829 which should greatly reduce merge conflicts in checked in bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #819.
It also includes tests for different platforms which are not supposed to be affected, so that we won't regress them in the future either.
The prefix
\x01char is necessary for Win32. See also msvc32_symbolify function in regen_atoms.py.