This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Switch from crossbeam_channel to condvar #951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building RLS inside rust-lang/rust, I see a weird SIGILL in crossbeam_channel: crossbeam-rs/crossbeam-channel#76 Switching to a condvar for synchronization seems to fix the issue.
This was referenced Jul 20, 2018
Closed
Closed
Merged
Contributor
Author
|
Obsoleted by #954 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building RLS inside rust-lang/rust, I see a weird SIGILL in
crossbeam_channel:
crossbeam-rs/crossbeam-channel#76
Switching to a condvar for synchronization seems to fix the issue.
I don't think that we need to merge this right away, it's better to get to the underlying issue first. However, if we are to update RLS in rust-lang/rust, we'll need to either merge this, or revert the managed concurrency PR.