This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Reenable lens test #948
Closed
Reenable lens test #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One round of CI was successful. Updating the PR to trigger another one. |
Member
|
The lens test was failing intermittently inside Rust. To test that you'll need to pull this branch into the RLS submodule and then |
It was non-deterministic. We've tried to eradicate some sources of non-determinism recently, let's check if it fixes the test.
Contributor
Author
|
Looks like current master of RLS does not exactly work with rust-lang/rust :-)
|
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's just see if this reliably passes CI