This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Switch to standard implementation method. #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoeyR
commented
Jul 11, 2018
Cargo.toml
Outdated
| @@ -44,3 +44,6 @@ json = "0.11" | |||
| [features] | |||
| default = [] | |||
| clippy = ["clippy_lints"] | |||
|
|
|||
| [patch.crates-io] | |||
There was a problem hiding this comment.
This is just to get the ci builds to pass until languageserver-types merges their PR and releases a version.
|
This will have to be coordinated with the vscode extension somehow since it adds a custom menu command to make use of the old |
ZoeyR
changed the title
|
|
|
Works good, thanks! |
Xanewok
added a commit
to Xanewok/rls-vscode
that referenced
this pull request
Jul 14, 2018
Introduced in the RLS with rust-lang/rls#936.
Xanewok
added a commit
to Xanewok/rls-vscode
that referenced
this pull request
Jul 14, 2018
Introduced in the RLS with rust-lang/rls#936.
fj
pushed a commit
to fj/rls-vscode
that referenced
this pull request
Feb 17, 2019
Introduced in the RLS with rust-lang/rls#936.
nemethf
added a commit
to nemethf/rls
that referenced
this pull request
Nov 22, 2019
rustDocument/implementations is not in use. Fix rust-lang#1593 @Xanewok: > We're not using it anymore since rust-lang#936 but the documentation is outdate.
nemethf
added a commit
to nemethf/rls
that referenced
this pull request
Nov 22, 2019
rustDocument/implementations is not in use. Fix rust-lang#1593 @Xanewok: > We're not using it anymore since rust-lang#936 but the documentation is outdate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the custom
FindImplsmethod and replaces it with the standardGotoImplementationmethod from version 3.6.0 of the LSP.