Skip to content

Conversation

@brauliobz
Copy link
Contributor

Part of #84

Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. 😍 otherwise.

>
> _StructField_ :
> &nbsp;&nbsp; [_OuterAttribute_]<sup>\*</sup>
> &nbsp;&nbsp; [_Visibility_]<sup>?</sup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since visibility contains EMPTY, the ? isn't needed here.

>
> _TupleField_ :
> &nbsp;&nbsp; [_OuterAttribute_]<sup>\*</sup>
> &nbsp;&nbsp; [_Visibility_]<sup>?</sup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise.

@mrhota
Copy link
Contributor

mrhota commented Jan 21, 2018

@brauliobz ping! this PR is just waiting on a couple small adjustments before merge

@Havvy Havvy mentioned this pull request Feb 7, 2018
@matthewjasper matthewjasper merged commit 45e4259 into rust-lang:master Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants