Struct grammar #237
Merged
Struct grammar #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility grammar already has `EMPTY` as an option.
matthewjasper
approved these changes
Feb 10, 2018
Contributor
matthewjasper
left a comment
matthewjasper
left a comment
There was a problem hiding this comment.
This looks good. One thought I had, but I think this is fine either way.
| > [IDENTIFIER] | ||
| > [_Generics_]<sup>?</sup> | ||
| > [_WhereClause_]<sup>?</sup> | ||
| > ( `{` _StructFields_<sup>?</sup> `}` | `;` ) |
Contributor
There was a problem hiding this comment.
Would it help to have this match the text and split this into StructStruct and UnitStruct?
Contributor
Author
There was a problem hiding this comment.
I think I considered that when I first reviewed @brauliobz 's grammar and found a reason against it. Not sure anymore though. I'd rather not mess with the PR anymore than needed right now.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #160 except I removed the
?s from visibility as they are extraneous.