Get/set thread name shims return errors for invalid handles #4004

YohDeadfall · 2024-10-30T23:39:48Z

YohDeadfall · 2024-10-31T21:08:30Z

So, I feel satisfied now. There was an issue with the thread identifier conversion causing ICEs, but that happens no more.

@rustbot review

RalfJung

Thanks for the PR!

src/concurrency/thread.rs

src/shims/unix/linux/foreign_items.rs

src/shims/unix/macos/foreign_items.rs

src/shims/unix/solarish/foreign_items.rs

src/shims/windows/foreign_items.rs

tests/pass-dep/libc/pthread-threadname.rs

src/shims/unix/linux/foreign_items.rs

bors · 2024-11-02T21:53:36Z

☔ The latest upstream changes (presumably #4009) made this pull request unmergeable. Please resolve the merge conflicts.

src/concurrency/thread.rs

src/shims/windows/foreign_items.rs

src/shims/windows/thread.rs

tests/pass-dep/libc/pthread-threadname.rs

src/concurrency/thread.rs

src/shims/unix/linux/foreign_items.rs

RalfJung · 2024-11-05T21:43:05Z

I will stop here, please re-check all the comments I left that you marked as resolved to ensure they are truly resolved.

@rustbot author

YohDeadfall · 2024-11-06T12:38:43Z

Seems to be fine now, @RalfJung. The previously lost suggestions are restored via 7d8fe12, and the latest were addressed by 853593e.

@rustbot review

RalfJung

Thanks!
I think we are getting close. :)

src/shims/unix/thread.rs

src/shims/windows/thread.rs

tests/pass-dep/libc/pthread-threadname.rs

src/shims/windows/handle.rs

src/shims/windows/thread.rs

tests/pass-dep/libc/pthread-threadname.rs

RalfJung · 2024-11-07T20:58:03Z

Awesome, thanks. :) Please squash. :D

RalfJung · 2024-11-08T06:46:11Z

@rustbot author

YohDeadfall · 2024-11-08T14:57:00Z

@rustbot review

rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Oct 31, 2024

RalfJung reviewed Nov 2, 2024

View reviewed changes

src/shims/unix/linux/foreign_items.rs Show resolved Hide resolved

RalfJung reviewed Nov 4, 2024

View reviewed changes

src/concurrency/thread.rs Outdated Show resolved Hide resolved

RalfJung reviewed Nov 4, 2024

View reviewed changes

src/concurrency/thread.rs Outdated Show resolved Hide resolved

RalfJung reviewed Nov 4, 2024

View reviewed changes

src/shims/windows/foreign_items.rs Show resolved Hide resolved

YohDeadfall force-pushed the thread-name-ice-fix branch from 5dbf95b to a1b9d0b Compare November 5, 2024 15:42

YohDeadfall mentioned this pull request Nov 5, 2024

Refine the Thread variant of Windows Handle enum #4014

Closed

RalfJung reviewed Nov 5, 2024

View reviewed changes

src/shims/windows/foreign_items.rs Outdated Show resolved Hide resolved

src/shims/windows/thread.rs Outdated Show resolved Hide resolved

tests/pass-dep/libc/pthread-threadname.rs Outdated Show resolved Hide resolved

RalfJung reviewed Nov 5, 2024

View reviewed changes

tests/pass-dep/libc/pthread-threadname.rs Outdated Show resolved Hide resolved

RalfJung reviewed Nov 5, 2024

View reviewed changes

src/concurrency/thread.rs Outdated Show resolved Hide resolved

RalfJung reviewed Nov 5, 2024

View reviewed changes

src/shims/unix/linux/foreign_items.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 5, 2024

rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 6, 2024

RalfJung reviewed Nov 6, 2024

View reviewed changes

src/shims/unix/thread.rs Outdated Show resolved Hide resolved

src/shims/unix/thread.rs Outdated Show resolved Hide resolved

src/shims/windows/thread.rs Outdated Show resolved Hide resolved

tests/pass-dep/libc/pthread-threadname.rs Outdated Show resolved Hide resolved

YohDeadfall commented Nov 6, 2024

View reviewed changes

src/shims/windows/handle.rs Show resolved Hide resolved

YohDeadfall commented Nov 6, 2024

View reviewed changes

src/shims/windows/thread.rs Show resolved Hide resolved

RalfJung reviewed Nov 6, 2024

View reviewed changes

tests/pass-dep/libc/pthread-threadname.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 8, 2024

Get/set thread name shims return errors for invalid handles

2a696cc

YohDeadfall force-pushed the thread-name-ice-fix branch from 84303a7 to 2a696cc Compare November 8, 2024 14:55

rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 8, 2024

RalfJung enabled auto-merge November 8, 2024 15:02

RalfJung added this pull request to the merge queue Nov 8, 2024

Merged via the queue into rust-lang:master with commit ec18aad Nov 8, 2024
7 checks passed

YohDeadfall deleted the thread-name-ice-fix branch November 8, 2024 17:07

Get/set thread name shims return errors for invalid handles #4004

Get/set thread name shims return errors for invalid handles #4004

Uh oh!

Conversation

YohDeadfall commented Oct 30, 2024

Uh oh!

YohDeadfall commented Oct 31, 2024

Uh oh!

RalfJung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Nov 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Nov 5, 2024

Uh oh!

YohDeadfall commented Nov 6, 2024

Uh oh!

RalfJung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Nov 7, 2024

Uh oh!

RalfJung commented Nov 8, 2024

Uh oh!

YohDeadfall commented Nov 8, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants