-
Notifications
You must be signed in to change notification settings - Fork 414
Closed
Labels
A-shimsArea: This affects the external function shimsArea: This affects the external function shimsA-windowsArea: affects only Windows targetsArea: affects only Windows targetsC-cleanupCategory: cleaning up our codeCategory: cleaning up our codeE-good-first-issueA good way to start contributing, mentoring is availableA good way to start contributing, mentoring is available
Description
Pull request #4004 followed the first proposal from #4004 (comment) which led to some ugliness in Windows shims. That should be fixed by wrapping the logic of Handle::from_scalar in a function with access to InterpCx. See thread_id_try_from for an example.
Metadata
Metadata
Assignees
Labels
A-shimsArea: This affects the external function shimsArea: This affects the external function shimsA-windowsArea: affects only Windows targetsArea: affects only Windows targetsC-cleanupCategory: cleaning up our codeCategory: cleaning up our codeE-good-first-issueA good way to start contributing, mentoring is availableA good way to start contributing, mentoring is available