Update to new nightly API #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cramertj are you thinking to rename |
|
@Nemo157 I've re-added it as |
aturon
approved these changes
Oct 1, 2018
Cargo.toml
Outdated
| @@ -9,3 +9,6 @@ members = [ | |||
| "futures-util", | |||
| "futures-test", | |||
| ] | |||
|
|
|||
| [patch.crates-io] | |||
| pin-utils = { git = "https://github.com/Kroisse/pin-utils.git", branch = "pin" } | |||
There was a problem hiding this comment.
Do we plan on publishing the needed changes here?
There was a problem hiding this comment.
These are actually already published-- I just have to update the path here.
This was referenced Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: decide what to do w/ compat, executor trait.
Where should the executor trait go? I know @carllerche at least prefers an executor trait that is generic on the type of future it accepts, so I don't think the exact API is totally decided.
-utilseems wrong, but I hesitate to add another crate for it (especially since futures-executor is the good name, and that's already taken).Includes some changes from #1266 (thanks, @Kroisse!)