Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Follow latest pinning API #1266

Closed
wants to merge 4 commits into from
Closed

[WIP] Follow latest pinning API #1266

wants to merge 4 commits into from

Conversation

Kroisse
Copy link
Contributor

@Kroisse Kroisse commented Sep 20, 2018 •
edited
Loading

There is no advanced changes with new API like using Pin<Rc<T>> or else. Just a direct conversion from before.

Note: it depends on rust-lang/pin-utils#9.

@Thomasdezeeuw
Copy link
Contributor

This would close #1265.

@Thomasdezeeuw
Copy link
Contributor

I think rust-lang/rust#54339 breaks even more stuff.

@Kroisse
Copy link
Contributor Author

Kroisse commented Sep 21, 2018

I've assumed that there is a bug in Box::pinned, or impl<'a, T, F> UnsafeFutureObj<'a, T> for Pin<Box<F>> in stdlib.

@Thomasdezeeuw Thank you. It'll be helpful to investigate it.

@Kroisse
Copy link
Contributor Author

Kroisse commented Sep 21, 2018 •
edited
Loading

It's getting harder than I'd thought...

@Kroisse Kroisse mentioned this pull request Sep 21, 2018
Closed
@cramertj cramertj mentioned this pull request Sep 25, 2018
Merged
@cramertj
Copy link
Member

cramertj commented Oct 1, 2018

Thanks for the PR! This was merged as part of #1268.

@cramertj cramertj closed this Oct 1, 2018
@JesseWright JesseWright mentioned this pull request Oct 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kroisse @Thomasdezeeuw @cramertj