Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add delay between build attempts #2276

Merged
merged 1 commit into from
Oct 14, 2023
Merged

add delay between build attempts #2276

merged 1 commit into from
Oct 14, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 14, 2023

this is the next try to resolve #2262 by adding a delay between build attempts, as a follow-up to #2264 which I didn't think through.

I'm not yet 100% certain about the other BuildQueue methods, right now it makes sense to me, but I would love feedback on this (specifically: should we add the delay-filtering in more places? )

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 14, 2023
Nemo157
Nemo157 approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to only filter them out here, the only weirdness I can see resulting is that we have a non-empty queue but the builders won't be do anything, but that'll be a very short duration and very rare.

src/config.rs Outdated Show resolved Hide resolved
@syphar syphar merged commit c8154ee into rust-lang:master Oct 14, 2023
5 checks passed
@syphar syphar deleted the build-attempt-delay branch October 14, 2023 17:43
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 14, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add minimum delay between build attempts
2 participants
@syphar @Nemo157