Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builds: add delay between build attempts for the same release #2264

Closed
wants to merge 1 commit into from
Closed

builds: add delay between build attempts for the same release #2264

wants to merge 1 commit into from

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 11, 2023

This resolves #2262

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 11, 2023
Nemo157
Nemo157 reviewed Oct 13, 2023
View reviewed changes
src/build_queue.rs
(
SELECT
CASE
WHEN MAX(b.build_time) IS NULL then TRUE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't create/update a build when these failures happen, so this will always just see null.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn you're right

@syphar syphar closed this Oct 13, 2023
@syphar syphar deleted the delay-between-retries branch October 13, 2023 13:51
@syphar syphar mentioned this pull request Oct 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add minimum delay between build attempts
2 participants
@syphar @Nemo157