Revert "Merge #1378" #1476
Merged
Revert "Merge #1378" #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank yoouuu!!! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Aug 15, 2018
1476: Revert "Merge #1378" r=carols10cents a=jtgeibel This reverts commit ba6c689, reversing changes made to 9b4a92c. This reverts the changes introduced in PR #1378. The deploy has already been rolled back and this will get master back into a clean state so that deploys can be made if other issues arise before this bug can be resolved. The code reverted by this PR was causing `cargo publish` to fail with a 404 error. The issue appears to be triggered because `cargo publish` includes an additional `/` at the beginning of its route. It is possible that civet removes this automatically before it gets to conduit's routing logic, and that hyper leaves the extra `/` intact, causing the routing logic to fail to find the correct handler. Co-authored-by: Justin Geibel <[email protected]>
Build succeeded |
jtgeibel
added a commit
to jtgeibel/crates.io-index-1
that referenced
this pull request
Sep 21, 2018
While trying to migrate the crates.io backend over to `hyper`, we ran into the issue that cargo hits API endpoints with URLs like `https://crates.io//api/v1/crates/new` (`//` before `api`). At the time, we rolled back the deploy and reverted the code in rust-lang/crates.io#1476 because it broke cargo API interactions. By removing the trailing `/` in the configuration here, cargo clients will send a single `/` and we won't need special case handling on the backend. I've looked though the history of `src/crates-io/lib.rs` in the `cargo` source, and as far back as rust-lang/cargo@9fba127 the code always appends `/api/v1` the the configured api URL. This is included in the oldest git tag for cargo, `v0.0.1-pre`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ba6c689, reversing changes made to 9b4a92c.
This reverts the changes introduced in PR #1378. The deploy has already been rolled back and this will get master back into a clean state so that deploys can be made if other issues arise before this bug can be resolved. The code reverted by this PR was causing
cargo publishto fail with a 404 error.The issue appears to be triggered because
cargo publishincludes an additional/at the beginning of its route. It is possible that civet removes this automatically before it gets to conduit's routing logic, and that hyper leaves the extra/intact, causing the routing logic to fail to find the correct handler.