Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
1378: Replace `civet` with `hyper` as http server r=carols10cents a=jtgeibel

This is a work in progress implementation switching from `civet` to `hyper` as the base http server.

This is based on `conduit-hyper` which I've updated to `hyper 0.11`.  That source code is [here](https://github.com/jtgeibel/conduit-hyper/blob/master/src/lib.rs).  A huge shout-out to @sfackler and @drbawb as this is forked from their repos.  I'm curios if either of you are still using this code and if you have any feedback.  I plan to eventually publish this crate on crates.io, so please let me know if you would like to be added/removed as an author or if you have any objections.

There are several things I wish to investigate further, including:

* I'm not yet sure if hyper handles panics.  I see no results searching for `catch_unwind`, so I'm assuming panics need to be handled in this layer.
* Add some tests
* request.remote_addr() is deprecated, also see: hyperium/hyper#1410 (comment)

Co-authored-by: Justin Geibel <[email protected]>
  • Loading branch information
bors-voyager[bot] and jtgeibel committed Aug 15, 2018
2 parents 9b4a92c + 52d01bc commit ba6c689
Show file tree
Hide file tree
Showing 4 changed files with 237 additions and 225 deletions.
Loading

0 comments on commit ba6c689

Please sign in to comment.