Skip to content

ci: Skip fragment check for Zulip client-side routing links #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoieni merged 2 commits into from
Oct 15, 2025
Merged

ci: Skip fragment check for Zulip client-side routing links #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbdfd7d
ci: Skip fragment check for Zulip client-side routing links
kingsword09 Oct 14, 2025
d1a085c
add comment
kingsword09 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,12 @@ jobs:
fail: true
# Accept the HTTP status code 429 (Too Many Requests) to avoid failing the workflow
# when the rate limit is exceeded.
# lychee strictly validates fragments; Zulip fragments are JS-routed and lack HTML anchors,
# which leads to false failures. Strip Zulip fragments and check the base URL instead.
# See lychee issues: https://github.com/lycheeverse/lychee/issues/1791
args: |
--no-progress
--include-fragments
--accept '100..=103, 200..=299, 429'
--remap '(https://rust-lang\.zulipchat\.com[^#]*)#.* $1'
.