ci: Skip fragment check for Zulip client-side routing links #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @marcoieni |
Member
Can you write something like this in the code as a comment? So that people know why the remap is there :) |
Contributor
Author
|
Please take another look. Thanks! @marcoieni |
marcoieni
approved these changes
Oct 15, 2025
Member
|
thanks a lot ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci error: https://github.com/rust-lang/crates-io-auth-action/actions/runs/18473910894/job/52633960065
After upgrading lychee-action to v2.5.0 (which uses lychee 0.19.1),
the fragment checking now correctly validates URL fragments. However,
Zulip uses client-side routing where fragments like
#narrow/channel/...are handled by JavaScript and don't exist as HTML anchors in the
server response.
Use the
--remapflag to strip fragments from Zulip URLs while stillchecking that the base URL is reachable. This allows fragment checking
to remain enabled for other links in the repository.
Related: lycheeverse/lychee#1675
Related: lycheeverse/lychee#1791