Skip to content

fix(ci): allow arbitrary indents for typos version extraction#16746

Merged
weihanglo merged 2 commits intorust-lang:masterfrom
raushan728:fix-16732
Mar 13, 2026
Merged

fix(ci): allow arbitrary indents for typos version extraction#16746
weihanglo merged 2 commits intorust-lang:masterfrom
raushan728:fix-16732

Conversation

@raushan728
Copy link
Contributor

Fixes #16732

Verified:

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_extract_typos_version() {
        // Standard indentation (6 spaces) works
        let content_6_spaces = "      uses: crate-ci/typos@v1.16.23";
        assert_eq!(
            extract_typos_version_from_content(content_6_spaces).unwrap().to_string(),
            "1.16.23"
        );

        // Different indentation (e.g., 8 spaces) also works now
        let content_8_spaces = "        uses: crate-ci/typos@v1.16.23";
        assert_eq!(
            extract_typos_version_from_content(content_8_spaces).unwrap().to_string(),
            "1.16.23"
        );
    }
}

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2026

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

@raushan728
Copy link
Contributor Author

r? @epage

@rustbot rustbot assigned epage and unassigned weihanglo Mar 13, 2026
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weihanglo weihanglo enabled auto-merge March 13, 2026 12:30
@weihanglo weihanglo added this pull request to the merge queue Mar 13, 2026
Merged via the queue into rust-lang:master with commit 843a683 Mar 13, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2026
@raushan728 raushan728 deleted the fix-16732 branch March 13, 2026 13:34
@ehuss
Copy link
Contributor

ehuss commented Mar 13, 2026

Please, in the future, use descriptive PR titles.

@weihanglo weihanglo changed the title Fix 16732 fix(ci): allow arbitrary indents for typos version extraction Mar 13, 2026
@raushan728
Copy link
Contributor Author

Please, in the future, use descriptive PR titles.

Sorry about the PR title but it was a small fix, so I didn't really understand how to give good title. I'll be more careful from next time

rust-bors bot pushed a commit to rust-lang/rust that referenced this pull request Mar 13, 2026
Update cargo submodule

21 commits in 90ed291a50efc459e0c380d7b455777ed41c6799..cbb9bb8bd0fb272b1be0d63a010701ecb3d1d6d3
2026-03-05 15:11:25 +0000 to 2026-03-13 14:34:16 +0000
- fix(git): preserve SCP-like submodule URLs for fetch (rust-lang/cargo#16744)
- Fix 16732 (rust-lang/cargo#16746)
- fix(rustdoc): switch to new `--emit` options (rust-lang/cargo#16739)
- fix(git): convert SCP-like submodule URLs to ssh:// format (rust-lang/cargo#16727)
- fix(core): typo (rust-lang/cargo#16738)
- CARGO_TARGET_DIR doesn't have to be relative (rust-lang/cargo#16735)
- chore(ci): Detect user changes to src/etc/man (rust-lang/cargo#16736)
- util: Exclude from iCloud Drive sync on macOS (rust-lang/cargo#16728)
- fix(compile): Stop on denying warnings without --keep-going  (rust-lang/cargo#16725)
- feat(shell): Support OSC 9;4 progress on ptyxis (rust-lang/cargo#16730)
- Let git decide when to run gc (rust-lang/cargo#16459)
- chore(deps): update cargo-semver-checks to v0.47.0 (rust-lang/cargo#16723)
- fix(compile): Turn warning summaries into errors also (rust-lang/cargo#16721)
- fix(fix): Switch from ad-hoc to structured warnings (rust-lang/cargo#16711)
- fix: ignore implicit std dependencies in `unused-crate-dependencies` lint (rust-lang/cargo#16677)
- chore(deps): update msrv (3 versions) to v1.92 (rust-lang/cargo#16716)
- chore(deps): update msrv (1 version) to v1.94 (rust-lang/cargo#16710)
- fix(script): surpress `unused_features` lint for embedded (rust-lang/cargo#16714)
- Split `build-dir` lock into dedicated lock  (rust-lang/cargo#16708)
- Add missing truncate when writing .crate files (rust-lang/cargo#16688)
- refactor(fix): Prep for annotate-snippets (rust-lang/cargo#16702)
@rustbot rustbot added this to the 1.96.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xtask-spellcheck fails to extract the typos version after a valid workflow reindent

5 participants