Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable flaky tests for now (#11821)" #13116

Closed

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

This reverts commit c890c64.

gix was updated to 0.41.0 (and later) a while back. Let's see how it goes.

resolves #11821

How should we test and review this PR?

Wait a see if those tests are still flaky in CI.

This reverts commit c890c64.

gix was updated to 0.41.0 (and later) a while back.
Let's see how it goes.
@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 5, 2023
@weihanglo
Copy link
Member Author

Okay. It seems that we have a different issue on Windows today. I don't have energy to work on it at this time. Closing.

1   1         Updating git repository `[https://foo.bar/foo/bar`](https://foo.bar/foo/bar%60)
    2    +warning: auto-detection of host provider took too long (>2000ms)
    3    +warning: see https://aka.ms/gcm/autodetect for more information.
    4    +fatal: A task was canceled.
    5    +warning: auto-detection of host provider took too long (>2000ms)
    6    +warning: see https://aka.ms/gcm/autodetect for more information.

@weihanglo weihanglo closed this Dec 5, 2023
@weihanglo weihanglo deleted the reenable-gix-auth-tests branch December 5, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitoxide auth tests sporadically failing
3 participants