Skip to content

Commit c890c64

Browse files
committed
Disable flaky tests for now (#11821)
The proper fix is in https://github.com/Byron/gitoxide/releases/tag/gix-v0.41.0 which unfortunately can't be used as it also comes with the latest `tempfile` v3.4 which causes other issues when compiling on some platforms. Thus we first disable the flaky tests, and re-enable them with the `gix` upgrade which should be possible once `tempfile` doesn't hinder `cargo` on some platforms anymore. Related to #11821
1 parent 3c35bf1 commit c890c64

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

tests/testsuite/git_auth.rs

+10
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,11 @@ fn setup_failed_auth_test() -> (SocketAddr, JoinHandle<()>, Arc<AtomicUsize>) {
105105
// Tests that HTTP auth is offered from `credential.helper`.
106106
#[cargo_test]
107107
fn http_auth_offered() {
108+
// TODO(Seb): remove this once possible.
109+
if cargo_uses_gitoxide() {
110+
// Without the fixes in https://github.com/Byron/gitoxide/releases/tag/gix-v0.41.0 this test is flaky.
111+
return;
112+
}
108113
let (addr, t, connections) = setup_failed_auth_test();
109114
let p = project()
110115
.file(
@@ -366,6 +371,11 @@ Caused by:
366371

367372
#[cargo_test]
368373
fn instead_of_url_printed() {
374+
// TODO(Seb): remove this once possible.
375+
if cargo_uses_gitoxide() {
376+
// Without the fixes in https://github.com/Byron/gitoxide/releases/tag/gix-v0.41.0 this test is flaky.
377+
return;
378+
}
369379
let (addr, t, _connections) = setup_failed_auth_test();
370380
let config = paths::home().join(".gitconfig");
371381
let mut config = git2::Config::open(&config).unwrap();

0 commit comments

Comments
 (0)