Skip to content

Conversation

@pheki
Copy link
Contributor

@pheki pheki commented Mar 11, 2020

After finding the regression I fixed in #61 I was very surprised that travis managed to compile #60 just fine on macOS (stable) and tried building it on my machine (which failed).

Then I realised that the config file was using --features tokio instead of use_tokio.

@rust-highfive
Copy link

r? @posborne

(rust_highfive has picked a reviewer for you, use r? to override)

@nastevens
Copy link
Member

nastevens commented Mar 11, 2020

I also built #60 on a Linux box but forgot the use_tokio feature. Should we maybe change this to --all-features in CI to avoid this problem in the future? On second thought, it looks like CI is specifically using the features to make sure that a normal build (without tokio) will still build. So I think what you have here is good 👍

@nastevens nastevens merged commit 62e267c into rust-embedded:master Mar 11, 2020
@pheki pheki deleted the fix-tokio-travis branch March 12, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants