Fix compilation with use_tokio feature #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @posborne (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
It looks like the abuse flagging by Travis CI is a known issue. From there it sounds like you can email [email protected] to get your account flag updated. It'd be really nice to have CI running on your PRs! Either way, the updates are much appreciated! |
Contributor
Author
|
Sent the email! Waiting for their fix now ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I've introduced a regression in #58 (sorry!) because I didn't run the tests with features (and travis didn't run as seen in #59 (comment)).
This fixes that regression by compiling
get_value_from_filealso whenfeature = "use_tokio".I also took the opportunity to use
?instead of all remainingtry!()macros.