Skip to content

Conversation

@Disasm
Copy link
Member

@Disasm Disasm commented Mar 14, 2020

No description provided.

@Disasm Disasm requested a review from a team as a code owner March 14, 2020 08:13
@Disasm
Copy link
Member Author

Disasm commented Mar 14, 2020

See also: xobs/vexriscv-rust#1

@laanwj
Copy link
Contributor

laanwj commented Mar 14, 2020

vexriscv support, nice!

@laanwj
Copy link
Contributor

laanwj commented Mar 14, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 14, 2020

👎 Rejected by too few approved reviews

@almindor
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 14, 2020

Build succeeded

@bors bors bot merged commit 255ef60 into master Mar 14, 2020
@bors bors bot deleted the release branch March 14, 2020 16:06
romancardenas pushed a commit that referenced this pull request Nov 17, 2023
38: link.x: Add .sdata2 sections r=Disasm a=laanwj

Clang doesn't seem to generate these, but GCC (8.3.0 at least) does. I'm trying to link secp256k1, which is a C library, to my Rust code so the linker script needs to include these sections too.

Co-authored-by: Wladimir J. van der Laan <[email protected]>
romancardenas pushed a commit that referenced this pull request Nov 17, 2023
Similar to #38, riscv compilers may also generate 'small ro data' `.srodata` sections.

This doesn't appear to be well documented, but see [this blog post](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain) for small amount of context.
romancardenas pushed a commit that referenced this pull request Nov 17, 2023
61: Update link.x r=almindor a=richardeoin

Similar to #38, riscv compilers may also generate 'small ro data' `.srodata` sections. 

This doesn't appear to be well documented, but see [this blog post](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain) for small amount of context.

Co-authored-by: Richard Meadows <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants