Prepare v0.7.4 #375
Prepare v0.7.4 #375
Conversation
372: asm/inline: explicitly use asm macro r=adamgreig a=jordens `asm!()` removed from prelude in current nightly rust-lang/rust#91728 close #371 This is also a good candidate for the cortex-m v0.7 series. Co-authored-by: Robert Jördens <[email protected]> Co-authored-by: Adam Greig <[email protected]>
369: Switch "native" check from being x86_64 only to checking `HOST` r=adamgreig a=TDHolmes If `HOST==TARGET`, we know we're compiling natively. Set a new `rustc` cfg for this and use it where we previously checked for `x86_64`. I was trying to run tests on my M1 MacBook Pro and couldn't since it isn't `x86_64`. Also, the currently configured nightly compiler for asm doesn't have M1 support, so I updated that. I'm fine reverting that change though, I can just do that locally, but I'm sure others will hit the same issue and it's a bit old... Co-authored-by: Tyler Holmes <[email protected]>
374: Construct a SysTick delay with a clock source r=adamgreig a=mciantyre Helpful for users who prefer an external clock source for their system timer. Proposing this as a 0.7 backwards-compatible change. Co-authored-by: Ian McIntyre <[email protected]>
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
S-waiting-on-review
|
LGTM, but wanted to ask, the bin files are much smaller now. Did we notice that back when the inline asm changes were originally updated? I see you said:
so are the file size changes all just like debug info? |
|
Good spot, that is kind of alarming. I'll check. |
|
I think this is mostly a quirk of GitHub's UI - the percentage in red is the new size relative to the old size, not the size of the delta, so |
|
OK, let's get this out there. bors r=thejpster |
|
Build succeeded! And happy new year! 🎉 |
I've created a new branch,
v0.7.x, which is currently at the latest non-breaking commit (so includes #346 #349 #347 #351 #339 #352 #348 #363 #362 #361 but does not include #342), to track the 0.7 series since master now contains breaking changes for v0.8.This PR (which targets the new branch) cherry-picks #372 #369 #374 and bumps the version to v0.7.4 (and updates CHANGELOG) ready for a new v0.7.4 release. Once complete I'll also backport the changelog entries and bump the version in master to 0.7.4.
I think this is everything that should be in 0.7 -- the only excluded PRs from master are #342 and #367 I believe, and I don't think we have any open PRs targeting 0.7 either.
Any other thoughts on items for inclusion in 0.7.4 (or other changelog entries I missed)?