Added support for a custom migration table name #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementation is done then :) |
jxs
requested changes
Jan 6, 2022
- The iter call isn't needed indeed, and can be replaced by adding an & - Added const DEFAULT_MIGRATION_TABLE_NAME - Removed TODO from tiberius driver
…efinery into custom_migration_table_name
jxs
approved these changes
Jan 6, 2022
|
Awesome, thanks! |
This was referenced Jan 6, 2022
|
Might be best to wait a little with releasing. I'd also like to implement the custom schema for the schema table ( see my comment in #205), that could go in the same minor release Edit: err, disregard. Seems I completely misunderstood the meaning of schema 😅 |
jxs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a custom name for the migration table (by default
refinery_schema_history).Motivation
I've seen quite some issues requesting this is one way or another:
Approach
The PR adds a new field to the
Runnerstruct,migration_table_nameand an associated functionset_migration_table_name. The value ofmigration_table_nameis passed around to the places it needs to be as a&str. Inrefinery_core::traits, there are 3const &str's, which now include a 'variable'%MIGRATION_TABLE_NAME%which must be replaced before being used, this is done everywhere correctly.Backwards compatibility
This PR does not break backwards compatibility, mostly. For most binaries, this PR does not break backwards compatibility. However, the traits
MigrateandAsyncMigratehave had changes to their functions, the only change to each function is the addition of a new parameter,migration_table_name. I doubt anyone uses these traits outside of therefinerycrate, but it is a breaking change.Modification to tests
The tests have been modified to conform with the updated function signatures, i.e. the
migration_table_nameparameterThanks.