Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "refinery_schema_history" to something starting with __ #176

Closed
omid opened this issue Sep 13, 2021 · 3 comments
Closed

Rename "refinery_schema_history" to something starting with __ #176

omid opened this issue Sep 13, 2021 · 3 comments

Comments

@omid
Copy link
Contributor

omid commented Sep 13, 2021

To be compatible with diesel print-schema command, I would suggest we can rename the migration table to something else which starts with __ (a double underscore).

@jxs
Copy link
Member

jxs commented Sep 14, 2021

hum, what is the advantage with this? Don't diesel and refinery kinda overlap? My issue with this is the same with changing the type on the version column: a breaking change that envolves manually renaming a table. For this I would prefer we actually go for #109 with the default being refinery_schema_history

@omid
Copy link
Contributor Author

omid commented Sep 14, 2021

There is an overlap between diesel_migrations and refinery.
There are some overlaps between refinery_cli and diesel_cli.

diesel cli can generate the schema.rs file, which is kinda required if you want to use diesel.

And diesel will skip tables that starts with __ in the schema.

@jxs
Copy link
Member

jxs commented Jan 6, 2022

addressed with #207

@jxs jxs closed this as completed Jan 6, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants