Collect gRPC info: search for Microsoft.AspNetCore.Hosting.HttpRequestIn Activity#1
Closed
gregkalapos wants to merge 2 commits intorusscam:fix/activity-reusefrom
gregkalapos:FixGrpcTest
Closed
Collect gRPC info: search for Microsoft.AspNetCore.Hosting.HttpRequestIn Activity#1gregkalapos wants to merge 2 commits intorusscam:fix/activity-reusefrom gregkalapos:FixGrpcTest
gregkalapos wants to merge 2 commits intorusscam:fix/activity-reusefrom
gregkalapos:FixGrpcTest
Conversation
Author
|
I naively though this will run on CI - of course it doesn't. I opened elastic#1235 to run all tests in CI to make sure everything is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from elastic#1228
I looked into the failing gRPC tests.
gRPC info is stored on an Activity called
Microsoft.AspNetCore.Hosting.HttpRequestIn. Prior to elastic#1228 we always created an Activity andMicrosoft.AspNetCore.Hosting.HttpRequestInwas always its parent (although I think this assumption was already way too optimistic). Now with elastic#1228 the agent either creates and Activity or reuses an existing one.Therefore this PR always searches up the Activity chain up to
Microsoft.AspNetCore.Hosting.HttpRequestInto read theTagson it which contains the gRPC info that we collect instead of hard-codingActivity.Current.Parentand reads its tags.