[Temp] gRPC fix with Activity reuse#1235
Closed
gregkalapos wants to merge 3 commits intoelastic:masterfrom
gregkalapos:FixGrpcTest
Closed
[Temp] gRPC fix with Activity reuse#1235gregkalapos wants to merge 3 commits intoelastic:masterfrom gregkalapos:FixGrpcTest
gregkalapos wants to merge 3 commits intoelastic:masterfrom
gregkalapos:FixGrpcTest
Conversation
This commit fixes a bug whereby `Activity.Current` should be used to set the TraceId if 1. it's not null 2. it's using W3C Id format 3. activity are not being ignored
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
==========================================
+ Coverage 81.47% 81.53% +0.05%
==========================================
Files 165 165
Lines 6850 6861 +11
==========================================
+ Hits 5581 5594 +13
+ Misses 1269 1267 -2
Continue to review full report at Codecov.
|
Contributor
|
Thanks @gregkalapos, I've incorporated this into #1228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test to run russcam#1 in CI.
No need to merge.