Ignore Github draft PRs #977
Conversation
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
+ Coverage 71.95% 71.98% +0.02%
==========================================
Files 65 65
Lines 5406 5411 +5
==========================================
+ Hits 3890 3895 +5
Misses 1210 1210
Partials 306 306
Continue to review full report at Codecov.
|
server/events/event_parser_test.go
Outdated
| @@ -131,6 +131,14 @@ func TestParseGithubPullEvent(t *testing.T) { | |||
| _, _, _, _, _, err = parser.ParseGithubPullEvent(&testEvent) | |||
| ErrEquals(t, "sender.login is null", err) | |||
|
|
|||
| // verify that draft PRs are treated as 'other' events | |||
There was a problem hiding this comment.
Can you write a separate test please.
|
When the PR is changed to non-draft it looks like a |
Yeah I think that would be good. |
|
Thanks for the review! The most recent commit should handle that event |
|
Awesome work! 🎉 |
|
so commits while a PR is a draft are ignored? |
Yes |
|
Is there any way one see a plan for their code without making a ready-for-review PR? You could run terraform locally, of course, but there are less technical people who might not have terraform setup locally, or they might not have the right permissions. |
Yeah, don't ignore draft PRs. That's what I do. |
|
Oh, cool. Glad it's configurable. Is there a way without making any PR at all? |
|
Atlantis only knows about PRs. |
Related to #491. This change would classify any pull request event coming from draft PRs as an 'OtherPullEvent'. As a result Atlantis will ignore the PR until it is ready for review, at which point new events would be classified as before.