Ignore Github draft PRs (#977)

* Ignore Github draft PRs

server/events/event_parser.go

@@ -416,15 +416,26 @@ func (e *EventParser) ParseGithubPullEvent(pullEvent *github.PullRequestEvent) (
 		err = errors.New("sender.login is null")
 		return
 	}
-	switch pullEvent.GetAction() {
-	case "opened":
-		pullEventType = models.OpenedPullEvent
-	case "synchronize":
-		pullEventType = models.UpdatedPullEvent
-	case "closed":
-		pullEventType = models.ClosedPullEvent
-	default:
+
+	if pullEvent.GetPullRequest().GetDraft() {
+		// if the PR is in draft state we don't care about the action type
+		// we can set the type to Other and ignore the PR
 		pullEventType = models.OtherPullEvent
+	} else {
+		switch pullEvent.GetAction() {
+		case "opened":
+			pullEventType = models.OpenedPullEvent
+		case "ready_for_review":
+			// when an author takes a PR out of 'draft' state a 'ready_for_review'
+			// event is triggered. We want atlantis to treat this as a freshly opened PR
+			pullEventType = models.OpenedPullEvent
+		case "synchronize":
+			pullEventType = models.UpdatedPullEvent
+		case "closed":
+			pullEventType = models.ClosedPullEvent
+		default:
+			pullEventType = models.OtherPullEvent
+		}
 	}
 	user = models.User{Username: senderUsername}
 	return

server/events/event_parser_test.go

@@ -160,6 +160,16 @@ func TestParseGithubPullEvent(t *testing.T) {
 	Equals(t, models.User{Username: "user"}, actUser)
 }
 
+func TestParseGithubPullEventFromDraft(t *testing.T) {
+	// verify that draft PRs are treated as 'other' events
+	testEvent := deepcopy.Copy(PullEvent).(github.PullRequestEvent)
+	draftPR := true
+	testEvent.PullRequest.Draft = &draftPR
+	_, evType, _, _, _, err := parser.ParseGithubPullEvent(&testEvent)
+	Ok(t, err)
+	Equals(t, models.OtherPullEvent, evType)
+}
+
 func TestParseGithubPullEvent_EventType(t *testing.T) {
 	cases := []struct {
 		action string
@@ -205,6 +215,10 @@ func TestParseGithubPullEvent_EventType(t *testing.T) {
 			action: "reopened",
 			exp:    models.OtherPullEvent,
 		},
+		{
+			action: "ready_for_review",
+			exp:    models.OpenedPullEvent,
+		},
 	}
 
 	for _, c := range cases {