Add CommentArgs to run step runner #693
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow the extra args passed in the comment to be used by run steps This should resolve runatlantis#670
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 72.37% 72.37% +<.01%
==========================================
Files 61 61
Lines 4658 4659 +1
==========================================
+ Hits 3371 3372 +1
Misses 1037 1037
Partials 250 250
Continue to review full report at Codecov.
|
|
Thanks Alex! Can you also update the docs? https://github.com/runatlantis/atlantis/blob/master/runatlantis.io/docs/custom-workflows.md#custom-run-command |
|
@lkysow pushed a new commit updating that, sorry I didn't realise the docs for the site were even in this same repo! |
|
Thanks Alex! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow the extra args passed in the comment to be used by run steps
This should resolve #670
@lkysow this seemed like an easy first issue to work on as you gave the info on how to implement in the issue 😄 - let me know if anything needs changing.