Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Run Command: Pass Args after -- #670

Closed
chasse-code opened this issue Jun 11, 2019 · 2 comments · Fixed by #693
Closed

Custom Run Command: Pass Args after -- #670

chasse-code opened this issue Jun 11, 2019 · 2 comments · Fixed by #693
Labels
feature New functionality/enhancement

Comments

@chasse-code
Copy link

chasse-code commented Jun 11, 2019 •
edited
Loading

Atlantis Version: 0.7.2
Description: When using Terragrunt, or another wrapper, we want to be able to control all aspects of terraform planning such as passing -destroy for example which is typically accomplished via the -- directive in the atlantis command.

Without this, we are having trouble adopting tools such as Terragrunt.

It would be great to create an Environment Variable that contains these extra arguments that can then be passed to the external command and let it handle what it can.
@lkysow lkysow added the feature New functionality/enhancement label Jun 11, 2019
@lkysow
Copy link
Member

lkysow commented Jun 11, 2019

Should be relatively easy. Add

		"COMMENT_ARGS":               strings.Join(ctx.CommentArgs, ","),

to https://github.com/runatlantis/atlantis/blob/master/server/events/runtime/run_step_runner.go#L40

rowleyaj added a commit to rowleyaj/atlantis that referenced this issue Jun 30, 2019
@rowleyaj
Add CommentArgs to run step runner
9448cd7 
This should allow the extra args passed in the comment to be used by
run steps

This should resolve runatlantis#670
rowleyaj added a commit to rowleyaj/atlantis that referenced this issue Jun 30, 2019
@rowleyaj
Add CommentArgs to run step runner
5b7c582 
This should allow the extra args passed in the comment to be used by
run steps

This should resolve runatlantis#670
rowleyaj added a commit to rowleyaj/atlantis that referenced this issue Jun 30, 2019
@rowleyaj
Add CommentArgs to run step runner
d7b81cb 
This should allow the extra args passed in the comment to be used by
run steps

This should resolve runatlantis#670
@rowleyaj rowleyaj mentioned this issue Jun 30, 2019
Merged
lkysow pushed a commit that referenced this issue Jul 11, 2019
@rowleyaj @lkysow
Add CommentArgs to run step runner (#693)
dd02dea 
Add CommentArgs to run step runner

This should allow the extra args passed in the comment to be used by
run steps

Fixes #670
@grimm26
Copy link
Contributor

grimm26 commented Mar 2, 2022

@chasse-code How are you using COMMENT_ARGS in your terragrunt workflow? Specifically, how are you handling the escaping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New functionality/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CommentArgs to run step runner rowleyaj/atlantis
3 participants
@grimm26 @lkysow @chasse-code