Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get mergeable status *before* changing build status #469

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Feb 11, 2019

Small refactor of changes from @pratikmallya via #454 (thanks!).

Get the Mergeable status of the PR before updating the
Status. This allows for the Status to be a required
Status for merging the PR. This allows us to use the
atlantis status as a Required status, which is the
configuration often used, since most deployments
want to ensure tf plans have all been successfully
applied before merging

Closes #453
Closes #454

Get the Mergeable status of the PR before updating the
Status. This allows for the Status to be a required
Status for merging the PR. This allows us to use the
atlantis status as a Required status, which is the
configuration often used, since most deployments
want to ensure tf plans have all been successfully
applied before merging

Issue: #453
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #469 into master will decrease coverage by 0.02%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   70.57%   70.55%   -0.03%     
==========================================
  Files          63       63              
  Lines        4241     4248       +7     
==========================================
+ Hits         2993     2997       +4     
- Misses       1027     1029       +2     
- Partials      221      222       +1
Impacted Files Coverage Δ
server/server.go 67.29% <ø> (-0.13%) ⬇️
server/events/models/models.go 85.26% <ø> (ø) ⬆️
server/events/project_command_builder.go 84.68% <100%> (+0.2%) ⬆️
server/events/project_command_runner.go 78.98% <33.33%> (+0.97%) ⬆️
server/events/command_runner.go 65.46% <50%> (-0.5%) ⬇️
server/events/vcs/github_client.go 70.96% <0%> (-2.43%) ⬇️
server/events/vcs/bitbucketcloud/client.go 39.66% <0%> (-0.5%) ⬇️
server/events/vcs/bitbucketserver/client.go 30.18% <0%> (-0.44%) ⬇️
server/events/terraform/terraform_client.go 75.26% <0%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b07938...4e42958. Read the comment docs.

@lkysow lkysow merged commit f4e1472 into master Feb 11, 2019
@lkysow lkysow deleted the mergeability branch February 11, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants