Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mergeable Apply Requirement is not useful #453

Closed
pratikmallya opened this issue Feb 4, 2019 · 2 comments
Closed

Mergeable Apply Requirement is not useful #453

pratikmallya opened this issue Feb 4, 2019 · 2 comments
Labels
feature New functionality/enhancement

Comments

@pratikmallya
Copy link
Contributor

When the mergeable apply requirement is used AND the atlantis status check is a required check, atlantis will always fail to apply. This is because, as soon as the atlantis apply comment is made, the status of the (required) check turns to pending, thus rendering the commit unmergeable
@pratikmallya
Copy link
Contributor Author

One way to fix this would be to get the mergeable status before updating the status check

@pratikmallya pratikmallya mentioned this issue Feb 4, 2019
Closed
pratikmallya added a commit to pratikmallya/atlantis that referenced this issue Feb 9, 2019
@pratikmallya
Allow "Mergeable" apply requirement to work
09782c4 
Get the Mergeable status of the PR before updating the
Status. This allows for the Status to be a required
Status for merging the PR. This allows us to use the
atlantis status as a Required status, which is the
configuration often used, since most deployments
want to ensure tf plans have all been successfully
applied before merging

Issue: runatlantis#453
@lkysow lkysow mentioned this issue Feb 11, 2019
Merged
@lkysow
Copy link
Member

lkysow commented Feb 11, 2019

Fixed in https://github.com/runatlantis/atlantis/releases/tag/v0.4.15

@lkysow lkysow added the feature New functionality/enhancement label Apr 9, 2019
@qugu qugu mentioned this issue Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New functionality/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pratikmallya @lkysow