refactor: e2e test ensure conftest command to check conftest version is greater or equal to specific version

[krrrr38]

what

• change testing-env image which contains conftest command
  • refactor: add conftest command into testing-image for refactoring e2e conftest ensure logic to upgrade conftest upgrading #2811 introduce it
• check e2e conftest ensure logic with conftest command, not conftest$version command.

why

Based on #2807 (comment) discussion, we want to remove e2e controller version specific conftest command like

atlantis/server/controllers/events/events_controller_e2e_test.go

Lines 1366 to 1372 in 6a7f79e

	// Will fail test if conftest isn't in path and isn't version >= 0.25.0
	func ensureRunningConftest(t *testing.T) {
	localPath, err := exec.LookPath(fmt.Sprintf("conftest%s", ConftestVersion))
	if err != nil {
	t.Logf("conftest >= %s must be installed to run this test", ConftestVersion)
	t.FailNow()
	}

.

This version specific dependency is hard to upgrade conftest automatically.

To remove version dependency, I want remove conftest$version command.

references

• Prevent manual PRs to update TF and CONFTEST versions #2638
• feat: renovate handle regexManagers to update conftest/tf versions #2807 (comment)
• refactor: add conftest command into testing-image for refactoring e2e conftest ensure logic to upgrade conftest upgrading #2811

[krrrr38]

version is greater than or equal logic is already implemented. so just remove conftest$version command dependency using conftest command.

atlantis/server/controllers/events/events_controller_e2e_test.go

Lines 1366 to 1392 in b6f3724

	// Will fail test if conftest isn't in path and isn't version >= 0.25.0
	func ensureRunningConftest(t *testing.T) {
	localPath, err := exec.LookPath(fmt.Sprintf("conftest%s", ConftestVersion))
	if err != nil {
	t.Logf("conftest >= %s must be installed to run this test", ConftestVersion)
	t.FailNow()
	}
	versionOutBytes, err := exec.Command(localPath, "--version").Output() // #nosec
	if err != nil {
	t.Logf("error running conftest version: %s", err)
	t.FailNow()
	}
	versionOutput := string(versionOutBytes)
	match := versionConftestRegex.FindStringSubmatch(versionOutput)
	if len(match) <= 1 {
	t.Logf("could not parse conftest version from %s", versionOutput)
	t.FailNow()
	}
	localVersion, err := version.NewVersion(match[1])
	Ok(t, err)
	minVersion, err := version.NewVersion(ConftestVersion)
	Ok(t, err)
	if localVersion.LessThan(minVersion) {
	t.Logf("must have contest version >= %s, you have %s", minVersion, localVersion)
	t.FailNow()
	}
	}

[nitrocode]

Nice job! This will make conftest upgrades much easier!