Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add conftest command into testing-image for refactoring e2e conftest ensure logic to upgrade conftest upgrading #2811

Merged

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Dec 17, 2022

what

  • add conftest command in testing-image, not conftest$version command

why

Based on #2807 (comment) discussion, we want to remove e2e ocontroller version specific conftest command like

// Will fail test if conftest isn't in path and isn't version >= 0.25.0
func ensureRunningConftest(t *testing.T) {
localPath, err := exec.LookPath(fmt.Sprintf("conftest%s", ConftestVersion))
if err != nil {
t.Logf("conftest >= %s must be installed to run this test", ConftestVersion)
t.FailNow()
}
.

This version specific dependency is hard to upgrade conftest automatically.

To remove version dependency, I just add conftest comand. I will change e2e by using this command in the next PR.

references

…conftest ensure logic to upgrade conftest upgrading
@krrrr38 krrrr38 requested a review from a team as a code owner December 17, 2022 22:49
@krrrr38 krrrr38 changed the title refactor: add contest command into testing-image for refactoring e2e conftest ensure logic to upgrade conftest upgrading refactor: add conftest command into testing-image for refactoring e2e conftest ensure logic to upgrade conftest upgrading Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants