Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] issue Closes #309 (moved the undo banner below reset button) #311

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- Metta Ong ([@ongspxm](https://github.com/ongspxm))
- Michael Corwin ([@mcorwin22](https://github.com/mcorwin22))
- Pradyumna Mahajan ([@pradyumnamahajan](https://github.com/pradyumnamahajan))
- Aadarsh Jha ([@renji18](https://github.com/renji18))

## Translators

Expand Down
2 changes: 1 addition & 1 deletion src/common/modules/CommonCss
15 changes: 8 additions & 7 deletions src/options/options.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,7 @@
</a>
<img class="icon-dismiss invisible" src="/common/img/close.svg" width="24" height="24" tabindex="0" data-i18n data-i18n-aria-label="__MSG_dismissIconDescription__"></span>
</div>
<div id="messageSuccess" aria-label="success message" data-i18n data-i18n-aria-label="__MSG_ariaMessageSuccess__" class="message-box success invisible fade-hide">
<span class="message-text">That worked!</span>
<a href="#">
<button type="button" class="message-action-button micro-button success invisible"></button>
</a>
<img class="icon-dismiss invisible" src="/common/img/close.svg" width="24" height="24" tabindex="0" data-i18n data-i18n-aria-label="__MSG_dismissIconDescription__"></span>
</div>

<div id="messageError" aria-label="error message" data-i18n data-i18n-aria-label="__MSG_ariaMessageError__" class="message-box error invisible fade-hide">
<span class="message-text">An error happened.</span>
<a href="#">
Expand Down Expand Up @@ -195,6 +189,13 @@ <h1 data-i18n="__MSG_titleAddonBehavior__">Addon behavior</h1>
<hr /><br />
<button data-i18n="__MSG_optionsResetButton__" type="button" id="resetButton">Reset all settings to defaults</button>
</div>
<div id="messageSuccess" aria-label="success message" data-i18n data-i18n-aria-label="__MSG_ariaMessageSuccess__" class="message-box success invisible fade-hide success-undo-message-box">
<span class="message-text">That worked!</span>
<a href="#">
<button type="button" class="message-action-button micro-button success invisible"></button>
</a>
<img class="icon-dismiss invisible" src="/common/img/close.svg" width="24" height="24" tabindex="0" data-i18n data-i18n-aria-label="__MSG_dismissIconDescription__"></span>
</div>
</form>
<p class="helper-text">
<span data-i18n="__MSG_translatorCredit__" data-opt-i18n-keep-children>
Expand Down
Loading