Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] issue Closes #309 (moved the undo banner below reset button) #311

Closed
wants to merge 3 commits into from

Conversation

renji18
Copy link

@renji18 renji18 commented Aug 19, 2023

Moved the code for undo banner below the reset button. Created a css class to add some margin between the banner and button

cinnamon-2023-08-19T155310+0530.webm

@renji18 renji18 changed the title Fix issue #309 Fix issue #309 (moved the undo banner below reset button) Aug 19, 2023
@rugk
Copy link
Owner

rugk commented Aug 21, 2023

Hi @renji18,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

You can (automatically) let issues close when a PR is merged by adding some "magic" text to your PR body. (Manually linked it now.)

BTW: Next time, try to avoid doing a pull request from the main branch, because you can run into problems when you have a "non-clean" main that does not follow this repo here (i.e. "upstream"). See this article for details. Anyway, this is only a tip for the next time. 😃

@renji18
Copy link
Author

renji18 commented Aug 22, 2023

Hi @rugk, thanks for the advice. I'll keep the advice you've given in mind.

But I'm kinda confused. Is this PR linked to the issue now. And is the issue resolved as it needed to be, so that it can be merged in the code.

@renji18 renji18 changed the title Fix issue #309 (moved the undo banner below reset button) [Fix] issue Closes #309 (moved the undo banner below reset button) Aug 22, 2023
@renji18
Copy link
Author

renji18 commented Aug 22, 2023

This PR is still open, and it doesn't seem that it's been linked with the issue as well. I tried to change to PR description but it doesn't seem to automatically link this PR with the issue

@renji18
Copy link
Author

renji18 commented Aug 22, 2023

I'll close this PR and create a new PR, using the trick and method you mentioned. Sorry for the inconvenience

@rugk
Copy link
Owner

rugk commented Aug 22, 2023

@renji18 it needs to be in the PR body (not title) that is why it likely did not work, just for the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants