exporter: Various refactors#21891
Merged
kjarosh merged 3 commits intoruffle-rs:masterfrom Oct 11, 2025
Merged
Conversation
kjarosh
added
exporter
| let s_lower = s.to_ascii_lowercase(); | ||
| if s_lower == "all" { | ||
| Ok(FrameSelection::All) | ||
| } else if let Ok(n) = s.parse::<u32>() { |
Collaborator
There was a problem hiding this comment.
This might be intentional, but NonZero<u32> implements FromStr directly
Member
Author
There was a problem hiding this comment.
Thanks, I'll fix that in a separate PR — I don't really want to include any changes here, just moving code around, it's easier to review
Dinnerbone
approved these changes
Oct 11, 2025
kjarosh
force-pushed
the
exporter-refactors
branch
from
fa2331a to
ef7b968
Compare
This refactor introduces structs Exporter and MovieExport. Exporter represents the instance of exporter and MovieExport represents the instance of a single SWF export.
kjarosh
force-pushed
the
exporter-refactors
branch
from
ef7b968 to
cf110b6
Compare
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Oct 12, 2025
------------------------------------------------------------------------------------------ duckstation.mk c117059c82f14fe119d0b23c1229156e3bbeba07 # Version: Commits on Oct 12, 2025 ------------------------------------------------------------------------------------------ GPU/HW: Fix crash when preloading texture replacements, ------------------------------------------------------------------------------------- hatari.mk 29b13aa04394391be010ca18d2e0ce70109c9685 # Version: Commits on Oct 12, 2025 ------------------------------------------------------------------------------------- Make control.c independent from the SDL Move the window embedding functions into screen.c to make control.c independent from the SDL headers., ---------------------------------------------------- pcsx2.mk v2.5.219 # Version: Commits on Oct 12, 2025 ---------------------------------------------------- - [Deps: Update Windows and Linux to Qt 6.10.0](PCSX2/pcsx2#13360) ----------------------------------------------------- ryujinx.mk 1.3.156 # Version: Commits on Oct 12, 2025 ----------------------------------------------------- Canary-1.3.156 ------------------------------------------------------------------------------------- snes9x.mk cdffce2e32bfc0305fd5489831d09b5e730bed9b # Version: Commits on Oct 12, 2025 ------------------------------------------------------------------------------------- qt: Update compatibility for Qt 6.10., ------------------------------------------------- vice.mk r45792 # Version: Commits on Oct 11, 2025 ------------------------------------------------- set tap_buffer=NULL after free(), fixes #2173 git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45792 379a1393-f5fb-40a0-bcee-ef074d9b53f7, ------------------------------------------------------------------------------------------- xenia-native.mk 62439cc24e6ffb738ba001b2bc2c3e7ea0ddc77f # Version: Commits on Oct 11, 2025 ------------------------------------------------------------------------------------------- [UI] Restored notification sending on window open/close, ----------------------------------------------------------------------------------- ymir.mk 20bf77d6eeff6da311e8a43d5fc91655148b8ad7 # Version: Commits on Oct 12, 2025 ----------------------------------------------------------------------------------- feat(updater): Cleanup unused code, structure update logic skeleton, --------------------------------------------------------------- ruffle.mk nightly-2025-10-12 # Version: Commits on Oct 12, 2025 --------------------------------------------------------------- ## What's Changed * exporter: Add more tests by @kjarosh in ruffle-rs/ruffle#21892 * debug_ui: Improve mask/maskee fields by @kjarosh in ruffle-rs/ruffle#21842 * exporter: Various refactors by @kjarosh in ruffle-rs/ruffle#21891 * `from_shumway/localconnection` test doesn't need image comparison by @Dinnerbone in ruffle-rs/ruffle#21898 * desktop: Prefer non-sRGB surface formats by @torokati44 in ruffle-rs/ruffle#20965 * avm1: Maintain two separate `_global`s for SWF 6- and 7+ by @moulins in ruffle-rs/ruffle#21863 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-10-11...nightly-2025-10-12, ------------------------------------------------- ecm.mk v6.19.0 # Version: Commits on Mar 23, 2024 ------------------------------------------------- Improvements and fixes for KDEInstallDirs documentation, ------------------------------------------------------------------------------------ box64.mk af437fa354f387fb563ded1a8db7c5051148b5cd # Version: Commits on Oct 12, 2025 ------------------------------------------------------------------------------------ [ARM64_DYNAREC] Fixed a typo in iret_to_epilog (#3059), ---------------------------------------------------------------------------------------- openmohaa.mk fb741a9a0b30ae9af9a0e553d69ba4fb4a5eae3c # Version: Commits on Oct 11, 2025 ---------------------------------------------------------------------------------------- Add Sys_OpenFolderInFileManager, -------------------------------------------------------------------------------------- stalker.mk a71de4f8a647e8e55572eac39efc9e3e90dfddbc # Version: Commits on Oct 12, 2025 -------------------------------------------------------------------------------------- xrEngine/FDemoRecord.cpp: ability to open editor from the demo record, ---------------------------------------------------------------------------------------- doomretro.mk 6c99b05fdaac67c6078f33a5d2527fc6d479df70 # Version: Commits on Oct 12, 2025 ---------------------------------------------------------------------------------------- Minor tweaks, ----------------------------------------------------------------------------------- tr1x.mk 69536afb65cb0f1bc3746f9593c9de30614f07b6 # Version: Commits on Oct 11, 2025 ----------------------------------------------------------------------------------- tr1/types: remove PHD_ANGLE, ----------------------------------------------------------------------------------- tr2x.mk 69536afb65cb0f1bc3746f9593c9de30614f07b6 # Version: Commits on Oct 11, 2025 ----------------------------------------------------------------------------------- tr1/types: remove PHD_ANGLE, ------------------------------------------------------------------------------------------ xash3d-fwgs.mk 4f444ee6eaa91369788114f415ea56cb3221f498 # Version: Commits on Oct 11, 2025 ------------------------------------------------------------------------------------------ engine: client: for goldsrc status messages, always mark them of goldsrc protocol, -------------------------------------------------------------------------------------------------- libretro-gearcoleco.mk d76579dba9daad6e0898997c2bec47cdba9aecf9 # Version: Commits on Oct 11, 2025 -------------------------------------------------------------------------------------------------- Fix default custom palette. #82, ------------------------------------------------------------------------------------------------ libretro-panda3ds.mk bac050fc4b08d0da13d371d9cfbe798287331794 # Version: Commits on Oct 12, 2025 ------------------------------------------------------------------------------------------------ Fastmem: Fix iOS/OSX checks (#813), --------------------------------------------------------------------------------------------- libretro-vba-m.mk 49773388e1568cdc698a5b41d95624d9697774c0 # Version: Commits on Oct 11, 2025 --------------------------------------------------------------------------------------------- Fix 3d6cad6d for revert of 56ea6456 Fixed with Claude. Signed-off-by: Rafael Kitover <rkitover@gmail.com>,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to add some structure to exporter code, and moves some code around to cli.rs, progress.rs, and exporter.rs. It removes some code duplication and makes it easier to restructure image processing in future PRs.