ci: Split the web build job in the nightly release workflow into extensions and demo+selfhosted+docs #19767

torokati44 · 2025-03-10T07:48:33Z

This builds on top of #19316.
What do y'all think?

torokati44 · 2025-03-10T07:49:54Z

Something like actions/runner#1182 would make duplicating the first 50 or so lines of tool setup unnecessary...

.github/workflows/release_nightly.yml

danielhjacobs · 2025-03-11T18:55:41Z

Something like actions/runner#1182 would make duplicating the first 50 or so lines of tool setup unnecessary...

Ancient issue, but some hope is given by actions/runner#1182 (comment) at least.

web/README.md

danielhjacobs · 2025-03-11T19:09:58Z

Makes sense to me, aside from the questions I asked.

danielhjacobs · 2025-03-11T19:11:07Z

Maybe add a TODO comment about the duplicated logic in both places it appears, pointing to actions/runner#1182

.github/workflows/release_nightly.yml

danielhjacobs · 2025-03-31T13:14:52Z

Support for YAML anchors is coming, but probably in the latter half of the year: actions/runner#1182 (comment)

danielhjacobs

If we're okay with bumping the minimum supported Safari version for the extension specifically to 16.4 (I'm fine with it), approved.

.github/workflows/release_nightly.yml

torokati44 · 2025-04-09T20:51:17Z

Thank you for the feedback! I'm going to merge tomorrow then, unless anyone objects until then.

…nsions and demo+selfhosted+docs

danielhjacobs · 2025-04-11T00:31:25Z

I don't know how I missed this but I think you did away with build:dual-wasm-repro

danielhjacobs · 2025-04-11T00:31:39Z

Not as an option but in the CI.

danielhjacobs · 2025-04-11T00:31:57Z

It needs to be used for selfhosted.

danielhjacobs · 2025-04-11T00:34:58Z

.github/workflows/release_nightly.yml

+          WASM_SOURCE: cargo_and_store
+        working-directory: web
+        shell: bash -l {0}
+        run: npm run build:repro


run: npm run build:dual-wasm-repro

@torokati44

--------------------------------------------------------------------------------------- amiberry.mk 12842ea3d17b48a30131081e2d6534bba6981615 # Version: Commits on Apr 11, 2025 --------------------------------------------------------------------------------------- bugfix: disable debug only DEV IDE entry from Expansions (fixes #1664) This entry should not be visible in release builds, ------------------------------------------------------------------------------------- azahar.mk 89d2e67459a82aac46f5e38c3a50d0a6213d5253 # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------- qt: Add quicksave / quickload hotkeys (#811) * qt: Add quicksave / quickload hotkeys * Adjusted strings * main.ui: Remove stray newline --------- Co-authored-by: David Griswold <[email protected]>, ------------------------------------------------------------------------------------------ duckstation.mk c192bd798bede54e8c97086a2a891d6a16f95f25 # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------------ Bus: Stub out 0x1F802080 Used by some homebrew., -------------------------------------------------------------------------------------- flycast.mk aff64d43d4ad9621532f33fdd70e0eccd1c2d2b2 # Version: Commits on Apr 11, 2025 -------------------------------------------------------------------------------------- libretro: don't restart the emu in retro_serialize_size Stop the emu in retro_serialize_size and don't restart it until after the state is saved in retro_serialize. This avoids issues when the actual state size is greater than what retro_serialize_size returned. Issue #1885, -------------------------------------------------------------------------------------- openmsx.mk 54d72a94b89be8eedc497ebe2fc6182d59d0b0e8 # Version: Commits on Apr 11, 2025 -------------------------------------------------------------------------------------- overhaul of the softwaredb.xml, ---------------------------------------------------- pcsx2.mk v2.3.264 # Version: Commits on Apr 10, 2025 ---------------------------------------------------- - [GameDB: Fix broken FMVs in Clock Tower 3](PCSX2/pcsx2#12509) , ------------------------------------------------------------------------------------- ppsspp.mk edf2975a2ce91d9f7b665e8e2195482519c2924f # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------- Merge pull request #20238 from hrydgard/mp3-mono-fix MP3 mono playback fix, ------------------------------------------------------------------------------------ rpcs3.mk 2d7ffaf07f45397216e89769415d05e51fb1f86c # Version: Commits on Apr 10, 2025 ------------------------------------------------------------------------------------ vk: Fix typo in NVIDIA-specific stencil unresolve path, --------------------------------------------------------------- ruffle.mk nightly-2025-04-11 # Version: Commits on Apr 11, 2025 --------------------------------------------------------------- ## What's Changed * build(deps): bump crossbeam-channel from 0.5.14 to 0.5.15 by @dependabot in ruffle-rs/ruffle#20055 * ci: Split the web build job in the nightly release workflow into extensions and demo+selfhosted+docs by @torokati44 in ruffle-rs/ruffle#19767 * web: Check if custom Map is defined as fluent loop is iterating by @danielhjacobs in ruffle-rs/ruffle#19977 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-04-10...nightly-2025-04-11, -------------------------------------------------------------------------------------- shadps4.mk 37d4cd091c0ff3d534380f686b986a5699da8f8b # Version: Commits on Apr 10, 2025 -------------------------------------------------------------------------------------- renderer_vulkan: Make some primitive state dynamic. (#2764) * renderer_vulkan: Make some primitive state dynamic. * renderer_vulkan: Silence MoltenVK primitive restart warning spam., ----------------------------------------------------------------------------------------- supermodel.mk 210fa3d153460b84b12a2671895674ac931cc7c1 # Version: Commits on Apr 10, 2025 ----------------------------------------------------------------------------------------- Workarounds no longer required., ----------------------------------------------------------------------------------- xemu.mk 2cc926588b9fea2aa5bd5b4882cb7440c6553991 # Version: Commits on Apr 11, 2025 ----------------------------------------------------------------------------------- nv2a/gl: Fix COLOR_LE_G8B8 GL surface format type, ------------------------------------------------------------------------------------ box64.mk 592a2a75bb1af3f167a274b2c5a27dff3a29447f # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------ [ANDROID] Adjusted some signals structure for Android/Bionic, ------------------------------------------------------------------------------------------- jazz2-native.mk 55fe908cb733cc1846c85ac191e61e7b35f0aae7 # Version: Commits on Apr 11, 2025 ------------------------------------------------------------------------------------------- Multiplayer, added more locks, ---------------------------------------------------------------------------------------- retroarch.mk 4c0744b6447a84bd48f06687df89da28afe9c856 # Version: Commits on Apr 11, 2025 ---------------------------------------------------------------------------------------- Merge pull request #17795 from pstef/selection-size_t, ---------------------------------------------------------------------------------------- doomretro.mk d500356f6f5219f942c86e52441a2f250a21dd27 # Version: Commits on Apr 11, 2025 ---------------------------------------------------------------------------------------- Check for `MF_SPECIAL` when randomly mirroring weapons for `r_mirroredweapons` CVAR, ----------------------------------------------------------------------------------------- sonicnexus.mk fa913619ac7a3ec1d5d3f67a1e663a56ebef9691 # Version: Commits on Jan 26, 2025 ----------------------------------------------------------------------------------------- Fix dev menu toggle, ----------------------------------------------------------------------------------- tr1x.mk 2aa0f2e161fed0fd9390d27b68f5e54fdadc6cd1 # Version: Commits on Apr 10, 2025 ----------------------------------------------------------------------------------- tr1/output: optimize uvw access, ----------------------------------------------------------------------------------- tr2x.mk 2aa0f2e161fed0fd9390d27b68f5e54fdadc6cd1 # Version: Commits on Apr 10, 2025 ----------------------------------------------------------------------------------- tr1/output: optimize uvw access, ------------------------------------------------------------------------------------------ xash3d-fwgs.mk 149593fea5c7845a84649965acf639e4238c5d15 # Version: Commits on Apr 10, 2025 ------------------------------------------------------------------------------------------ engine: server: hide Cmd_ForwardToServer call under XASH_DEDICATED just in case, fixes build with debug, -------------------------------------------------------------------------------------------------- libretro-beetle-psx.mk 5d2137e5f15db3b52583e8246bcf2669cebb147b # Version: Commits on Apr 11, 2025 -------------------------------------------------------------------------------------------------- Fetch translations & Recreate libretro_core_options_intl.h, --------------------------------------------------------------------------------------------- libretro-bsnes.mk b102d6d5817b25aa059b573cd3b7675f2e375fa4 # Version: Commits on Apr 11, 2025 --------------------------------------------------------------------------------------------- Fetch translations & Recreate libretro_core_options_intl.h, -------------------------------------------------------------------------------------------- libretro-dice.mk 127026f263762bff33a94172354819792b204b89 # Version: Commits on Apr 11, 2025 -------------------------------------------------------------------------------------------- Merge pull request #32 from mittonk/dat_file Arcade DAT file., ---------------------------------------------------------------------------------------------- libretro-fceumm.mk 43e6496351b544df0de692fbb01b2a6942073f5c # Version: Commits on Apr 11, 2025 ---------------------------------------------------------------------------------------------- Linker fixes, ----------------------------------------------------------------------------------------------- libretro-flycast.mk aff64d43d4ad9621532f33fdd70e0eccd1c2d2b2 # Version: Commits on Apr 11, 2025 ----------------------------------------------------------------------------------------------- libretro: don't restart the emu in retro_serialize_size Stop the emu in retro_serialize_size and don't restart it until after the state is saved in retro_serialize. This avoids issues when the actual state size is greater than what retro_serialize_size returned. Issue #1885, ----------------------------------------------------------------------------------------------- libretro-geolith.mk 1391cef3d373cd2aaf4f8a0478b9d6f831c7dfac # Version: Commits on Apr 11, 2025 ----------------------------------------------------------------------------------------------- libretro: Peform audio callback after video callback, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk edf2975a2ce91d9f7b665e8e2195482519c2924f # Version: Commits on Apr 11, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #20238 from hrydgard/mp3-mono-fix MP3 mono playback fix, -------------------------------------------------------------------------------------------- slang-shaders.mk 01ba6d8a9323334780a9fbd36e6528d0b5263cb9 # Version: Commits on Apr 11, 2025 -------------------------------------------------------------------------------------------- Add soft-pixel-art shaders (#693) - A modified xSoft shader for pixel art style.,

torokati44 added A-build Area: Build scripts & CI github_actions Pull requests that update GitHub Actions code T-refactor Type: Refactor / Cleanup labels Mar 10, 2025

danielhjacobs reviewed Mar 11, 2025

View reviewed changes

.github/workflows/release_nightly.yml Outdated Show resolved Hide resolved

danielhjacobs reviewed Mar 11, 2025

View reviewed changes

web/README.md Outdated Show resolved Hide resolved

danielhjacobs reviewed Mar 12, 2025

View reviewed changes

.github/workflows/release_nightly.yml Outdated Show resolved Hide resolved

danielhjacobs mentioned this pull request Mar 12, 2025

extension: Don't build vanilla WASM module for web extensions #19316

Closed

torokati44 force-pushed the no-dual-wasm-extensions branch from 3299304 to dd586d7 Compare April 4, 2025 06:32

torokati44 marked this pull request as ready for review April 4, 2025 09:05

danielhjacobs approved these changes Apr 7, 2025

View reviewed changes

.github/workflows/release_nightly.yml Show resolved Hide resolved

.github/workflows/release_nightly.yml Show resolved Hide resolved

torokati44 force-pushed the no-dual-wasm-extensions branch from dd586d7 to 3e76263 Compare April 9, 2025 20:50

danielhjacobs and others added 3 commits April 10, 2025 18:31

extension: Don't build vanilla WASM module for web extensions

f54adcf

docs: Add info about a reproducible build with dual-wasm support

48a78d4

ci: Split the web build job in the nightly release workflow into exte…

d9bdc45

…nsions and demo+selfhosted+docs

torokati44 force-pushed the no-dual-wasm-extensions branch from 3e76263 to d9bdc45 Compare April 10, 2025 16:31

torokati44 enabled auto-merge (rebase) April 10, 2025 16:32

torokati44 merged commit f9681a2 into ruffle-rs:master Apr 10, 2025
22 checks passed

danielhjacobs reviewed Apr 11, 2025

View reviewed changes

danielhjacobs mentioned this pull request Apr 11, 2025

ci: Build dual-wasm for selfhosted/demo/docs #20059

Merged

Uh oh!

ci: Split the web build job in the nightly release workflow into extensions and demo+selfhosted+docs #19767

ci: Split the web build job in the nightly release workflow into extensions and demo+selfhosted+docs #19767

Uh oh!

Conversation

torokati44 commented Mar 10, 2025

Uh oh!

torokati44 commented Mar 10, 2025

Uh oh!

Uh oh!

danielhjacobs commented Mar 11, 2025

Uh oh!

Uh oh!

danielhjacobs commented Mar 11, 2025

Uh oh!

danielhjacobs commented Mar 11, 2025

Uh oh!

Uh oh!

danielhjacobs commented Mar 31, 2025

Uh oh!

danielhjacobs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

torokati44 commented Apr 9, 2025

Uh oh!

Uh oh!

danielhjacobs commented Apr 11, 2025

Uh oh!

danielhjacobs commented Apr 11, 2025

Uh oh!

danielhjacobs commented Apr 11, 2025

Uh oh!

danielhjacobs Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants