Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update translations #18497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RuffleBuild
Copy link
Collaborator

New Crowdin pull request with translations 🎉

@RuffleBuild RuffleBuild added T-chore Type: Chore (like updating a dependency, it's gotta be done) A-i18n Area: Internationalization & Localization labels Nov 6, 2024
@@ -23,6 +24,7 @@ GenericName[ja]=Flashプレイヤー
GenericName[ko]=플래시 플레이어
GenericName[nl]=Flash-speler
GenericName[pl]=Odtwarzacz Flash
GenericName[pt]=Flash Player
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might become a Portuguese linguist after these reviews, but I'll bet 5€ it should be Reprodutor Flash here.

recent-clear = Limpar
theme = Tema
theme-system = Padrão do sistema
theme-light = Claro
theme-dark = Escuro
# See for context https://github.com/FeralInteractive/gamemode
gamemode = Modo de jogo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be translated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add to the context for this source string that "transliteration only please, and only where applies"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not touching any context anymore 😄

The context already mentions it's a name of software, the question is whether adding further context will help

@@ -56,6 +59,7 @@ Keywords[ja]=flash;swf;プレイヤー;エミュレーター;rust
Keywords[ko]=플래시;swf;플레이어;에뮬레이터;rust
Keywords[nl]=flash;swf;speler;emulator;rust
Keywords[pl]=flash;swf;odtwarzacz;emulator;rust
Keywords[pt]=flash;swf;player;emulador;rust
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be player -> reprodutor assuming the above is correct. Similarly in other places with keywords

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 3 times, most recently from c5bc7f9 to 4da2873 Compare November 9, 2024 21:06
@@ -23,3 +23,10 @@ theme = Tema
theme-system = Predeterminado del sistema
theme-light = Claro
theme-dark = Oscuro
# See for context https://github.com/FeralInteractive/gamemode
gamemode = Modo de juego
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, probably shouldn't be translated

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 7 times, most recently from ae0348c to 9308904 Compare November 16, 2024 21:06
theme-light = فاتح
theme-dark = داكن
# See for context https://github.com/FeralInteractive/gamemode
gamemode = وضع اللعبة
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, it seems fully translated instead of transliterated. Added a comment on crowdin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-i18n Area: Internationalization & Localization T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants