Add change log links to gem page

[olivierlacan]

This adds a new changelog column to the linksets table and displays
that change log alongside the existing linkset links.

This is a draft, there may be tests we haven't thought of updating with @jaymcgavren but we will if necessary.

Fixes #578

[evanphx]

Where is the changelog value pulled from though? I don't see how it's set.

[olivierlacan]

@evanphx It's not being pulled from anywhere at the moment since it would need to be a new gemspec key. But there's still this gem edit page I had no idea about: https://github.com/rubygems/rubygems.org/blob/master/app/views/rubygems/edit.html.erb

[dwradcliffe]

Based on the other PRs in progress, it sounds like editing via the website was going to be discouraged. Given that, should this new link only pull from the gemspec? Just a thought.

[olivierlacan]

@dwradcliffe Sounds like a reasonable thing to do. I was amazed it's possible to override Linkset values, that said I don't think there's an active route for that gem edit page. Could be wrong.

This PR doesn't pull from anything, it's just ready to receive a new key as long as the key is named changelog.

[evanphx]

@olivierlacan There doesn't need to be a new gemspec key. The code can use the metadata keys. We're generally not adding any new gemspec fields.

[dwradcliffe]

@olivierlacan There is an active route to edit gems (

rubygems.org/config/routes.rb

Line 122 in 21e3961

resources :rubygems, :path => 'gems', :only => [:show, :edit, :update] do

) so that template would be used.

[kbrock]

👍 to adding it to the metadata

[igrep]

👍 I expect this feature to be merged! It'll make much easier to see a new version's change before updating the gem. 🙏

[olivierlacan]

Makes sense to me. Will update soon.

[kbrock]

@olivierlacan when this merges, can you double check that #724 adds changelog_uri key?

OTOH, if #724 goes through first, I will ping you so you can add the changelog_uri key to the new metadata hash.

[davefp]

@olivierlacan As a result of #610 a large chunk of the repo's history was re-written. Please rebase your PR so that it will merge cleanly. Thanks!

(There are further details on the blog: http://blog.rubygems.org/2015/02/01/rewriting-history.html)

[kbrock]

After 724 goes through, I'll rebase this one.

[olivierlacan]

@kbrock I'm going to entirely re-commit this PR with master so I can make it easily mergeable into #724 when that's done.

[kbrock]

@olivierlacan I was thinking that we would not add changelog in the form. Just read it out of the meta-data.

I think it would be great if the gemspec were the source for all gem metadata. Did you have something similar in mind?

[olivierlacan]

@kbrock Oh yeah, my bad. I'll nix that.

[olivierlacan]

@kbrock Just force-pushed a removal of the edit changelog input in the form.

[olivierlacan]

Rebased.

[indirect]

I am 👍 on this, reading a changelog link out of the gemspec metadata hash seems good to me.

[arthurnn]

I am also 👍 on this, however I would like us to finish #1127 first, before adding more links.

[homu]

☔ The latest upstream changes (presumably #1209) made this pull request unmergeable. Please resolve the merge conflicts.

[kbrock]

@olivierlacan #1234 merged - will look into the best way of getting this in.

Do you care if there is a field on a form? Or just reading from gemset.metadata[:changelog_uri] is good enough for you?

[olivierlacan]

Weren't we trying to move away from allowing those fields to be edited on the site? I think the metadata is perfect.

…

On January 6, 2017 at 6:35:59 PM, Keenan Brock ***@***.******@***.***)) wrote: @olivierlacan(https://github.com/olivierlacan) #1234(#1234) merged - will look into the best way of getting this in. Do you care if there is a field on a form? Or just reading from gemset.metadata[:changelog_uri] is good enough for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(#728 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAEBnlGh10LuZga8ggzQf6iCG9q3LbWQks5rPs_fgaJpZM4C3YAd).

[indirect]

👍

[olivierlacan]

Closing since we @kbrock made #1553 with no migration required.