Skip to content

add changelog link to rubygem linkset#1047

Closed
farukaydin wants to merge 1 commit into
rubygems:masterfrom
farukaydin:changelog-link
Closed

add changelog link to rubygem linkset#1047
farukaydin wants to merge 1 commit into
rubygems:masterfrom
farukaydin:changelog-link

Conversation

@farukaydin
Copy link
Copy Markdown
Member

Related with #728, #324

cc: @sferik @qrush

@qrush
Copy link
Copy Markdown
Member

qrush commented Aug 24, 2015

Nice. I'd love for us to parse this out of the gemspec too.

@arthurnn
Copy link
Copy Markdown
Member

Is this on part of the gemspec? cc @drbrain
I am ok with us moving forward with this and do the parse in a next PR.
@dwradcliffe @qrush @sferik if you are all good with this change, I can take care of merging it, and deploying it and run the migration.

@arthurnn
Copy link
Copy Markdown
Member

@olivierlacan thoughts?

@olivierlacan
Copy link
Copy Markdown
Contributor

@arthurnn I'm pretty sure we have a nice PR idea (it might even already be on master) where everything was moved to the serialized column instead of adding discrete columns for these new (and valuable) pieces of metadata. I'd be interested in going that way rather than adding yet another column because it seems unlikely we would query by it.

@kbrock
Copy link
Copy Markdown
Contributor

kbrock commented Nov 8, 2015

I too want this in the serialized metadata column.
I really want changelog links in, but would prefer to go the route of #724

Also, I promise to fix #728 once #724 merges.

@olivierlacan
Copy link
Copy Markdown
Contributor

While testing #1104 (comment) I noticed that linksets SELECTs were consistently the worse performing queries from the rubygem GET endpoint. I'd really like to help @kbrock with that serialized metadata idea, I feel like that would improve the performance of the API endpoint by about a third on the SQL-side alone.

@arthurnn
Copy link
Copy Markdown
Member

I will be closing this, as I think we should have this data as serialized metadata. We already have the metadata been populated from the gemspec,

metadata: spec.metadata || {},

Thanks for the PR.

@arthurnn arthurnn closed this Nov 27, 2015
@olivierlacan
Copy link
Copy Markdown
Contributor

:thumbs_up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants