Skip to content

Just updated coverage.#399

Merged
cmeiklejohn merged 5 commits into
masterfrom
just_updated_specs
Feb 6, 2012
Merged

Just updated coverage.#399
cmeiklejohn merged 5 commits into
masterfrom
just_updated_specs

Conversation

@cmeiklejohn
Copy link
Copy Markdown
Contributor

Addresses some concerns discovered and raised in #390.

Add coverage and resolve problem where versions don't show in just updated when there is only one.

@cmeiklejohn
Copy link
Copy Markdown
Contributor Author

Eeeek. Some confusion here on my part. A gem should not show up in just updated if it's a brand new gem with it's first version. Updating the cucumber scenario to reflect this.

We do run into an interesting scenario however, where a new gem, once it has two versions released, will show it's first version in the just updated section incorrectly (if there's a small number of gems, which is not a realistic case, or the window of time between releases is small). The correct behavior of just updated in this case would be to show only gems with more than one version, with it's first version excluded.

Sound correct?

@rthbound
Copy link
Copy Markdown

rthbound commented Feb 3, 2012

That bit sounds correct. Does this account for cases like this one for the launchy gem:

I kind of think you'd want both of these appearing.
2.0.3 July 17, 2011 java
2.0.3 July 17, 2011

cmeiklejohn added a commit that referenced this pull request Feb 6, 2012
@cmeiklejohn cmeiklejohn merged commit ad75b45 into master Feb 6, 2012
@cmeiklejohn
Copy link
Copy Markdown
Contributor Author

Merging for existing coverage before changing it.

@dwradcliffe dwradcliffe deleted the just_updated_specs branch September 26, 2014 23:21
sonalkr132 added a commit that referenced this pull request Dec 19, 2016
5.0.0 / 2016-11-05

Major enhancements

Cleanup deprecated code targeted Ruby 1.8

Bug fixes
Ensure badge data is included in result of JsonIndex template.
Ensure items in the nil section are displayed in HTML output. Issue #399 by Daniel Svensson.
Parse rb_intern_const correctly in C. PR #381 by Sho Hashimoto.
Fix broken assets caused by #335 when serving ri. PR #360 by Alex Wood.
Don't try to parse svg files. Issue #350 by Sigurd Svela.

Minor enhancements

Improve class name expansion/resolution in ri. PR #400 by NARUSE, Yui
Improve performance of document generation. PR #397 by Yusuke Endoh.

4.3.0 / 2016-11-04

Minor enhancements
Removed json dependency for Ruby 2.4.0

End to support Ruby 1.8.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants