Added cukes for just_updated versions in home view#390
Closed
rthbound wants to merge 2 commits into
Closed
Conversation
Contributor
|
These are not passing for me against rubygems.org/master... are they for you? |
Author
|
Ran it against master before leaving the office... all passed. |
Contributor
|
Still failing for me: Scenario: Just updated # features/homepage.feature:26
Given I am signed up as "email@person.com" # features/step_definitions/clearance/clearance_steps.rb:37
And I have an API key for "email@person.com/password" # features/step_definitions/api_steps.rb:1
And I have a gem "sandworm" with version "1.0.0" # features/step_definitions/gem_steps.rb:1
And I have a gem "sandworm" with version "2.0.0" # features/step_definitions/gem_steps.rb:1
And I have a gem "fireworm" with version "1.0.0" # features/step_definitions/gem_steps.rb:1
And I push the gem "sandworm-1.0.0.gem" with my API key # features/step_definitions/api_steps.rb:8
And I push the gem "sandworm-2.0.0.gem" with my API key # features/step_definitions/api_steps.rb:8
And I push the gem "fireworm-1.0.0.gem" with my API key # features/step_definitions/api_steps.rb:8
When I am on the homepage # features/step_definitions/web_steps.rb:44
Then I should see the following just updated gems: # features/step_definitions/view_steps.rb:15
| fireworm (1.0.0) |
| sandworm (2.0.0) |
| sandworm (1.0.0) |
<["fireworm (1.0.0)", "sandworm (2.0.0)", "sandworm (1.0.0)"]> expected but was
<["sandworm (2.0.0)", "sandworm (1.0.0)"]>. (MiniTest::Assertion)
./features/step_definitions/view_steps.rb:16:in `/^I should see the following just updated gems:$/'
features/homepage.feature:37:in `Then I should see the following just updated gems:' |
…n just_updated on home page
Author
|
It's strange that mapping the text of the links in that div is only bringing back gems of one type (and strange that it's always limited to the first type pushed). Haven't been able to figure that out. When pushing multiple versions of the same gem, the tests pass. Try to push a different gem and tests fail. |
Merged
Contributor
|
Closing this one out in favor of #399. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just Updated gems/versions need some test coverage.