Skip to content

Added cukes for just_updated versions in home view#390

Closed
rthbound wants to merge 2 commits into
rubygems:masterfrom
rthbound:just_updated_tests
Closed

Added cukes for just_updated versions in home view#390
rthbound wants to merge 2 commits into
rubygems:masterfrom
rthbound:just_updated_tests

Conversation

@rthbound
Copy link
Copy Markdown

Just Updated gems/versions need some test coverage.

@cmeiklejohn
Copy link
Copy Markdown
Contributor

These are not passing for me against rubygems.org/master... are they for you?

@rthbound
Copy link
Copy Markdown
Author

Ran it against master before leaving the office... all passed.

@cmeiklejohn
Copy link
Copy Markdown
Contributor

Still failing for me:

Scenario: Just updated                                    # features/homepage.feature:26
    Given I am signed up as "email@person.com"              # features/step_definitions/clearance/clearance_steps.rb:37
    And I have an API key for "email@person.com/password"   # features/step_definitions/api_steps.rb:1
    And I have a gem "sandworm" with version "1.0.0"        # features/step_definitions/gem_steps.rb:1
    And I have a gem "sandworm" with version "2.0.0"        # features/step_definitions/gem_steps.rb:1
    And I have a gem "fireworm" with version "1.0.0"        # features/step_definitions/gem_steps.rb:1
    And I push the gem "sandworm-1.0.0.gem" with my API key # features/step_definitions/api_steps.rb:8
    And I push the gem "sandworm-2.0.0.gem" with my API key # features/step_definitions/api_steps.rb:8
    And I push the gem "fireworm-1.0.0.gem" with my API key # features/step_definitions/api_steps.rb:8
    When I am on the homepage                               # features/step_definitions/web_steps.rb:44
    Then I should see the following just updated gems:      # features/step_definitions/view_steps.rb:15
      | fireworm (1.0.0) |
      | sandworm (2.0.0) |
      | sandworm (1.0.0) |
      <["fireworm (1.0.0)", "sandworm (2.0.0)", "sandworm (1.0.0)"]> expected but was
      <["sandworm (2.0.0)", "sandworm (1.0.0)"]>. (MiniTest::Assertion)
      ./features/step_definitions/view_steps.rb:16:in `/^I should see the following just updated gems:$/'
      features/homepage.feature:37:in `Then I should see the following just updated gems:'

@rthbound
Copy link
Copy Markdown
Author

It's strange that mapping the text of the links in that div is only bringing back gems of one type (and strange that it's always limited to the first type pushed). Haven't been able to figure that out.

When pushing multiple versions of the same gem, the tests pass. Try to push a different gem and tests fail.

@cmeiklejohn
Copy link
Copy Markdown
Contributor

Closing this one out in favor of #399.

@cmeiklejohn cmeiklejohn closed this Feb 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants